Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ApplicationVerification] Send verification E-Mails after creating an application #836

Closed
sarahsporck opened this issue Mar 2, 2023 · 5 comments · Fixed by #870
Closed
Assignees
Labels
prio: high Issue must be solved within the next weeks. Task
Milestone

Comments

@sarahsporck
Copy link
Contributor

sarahsporck commented Mar 2, 2023

Is your feature request related to a problem? Please describe.
The referenced organizations of an application need to be informed and verify an application.

Describe the solution you'd like
When a user submits an application and it is stored in the DB, the referenced organizations should each receive a verification e-mail. Think about the text. There already exists a utility to send e-mails in the backend.

[EDIT] The url should be encoded, so that outlook can pick it up. See: #828

Blocked by

@sarahsporck sarahsporck added Task blocked Task or user story can not be continued at the moment labels Mar 2, 2023
@sarahsporck sarahsporck added this to the Bayern Launch milestone Mar 2, 2023
@sarahsporck sarahsporck added the prio: high Issue must be solved within the next weeks. label Mar 2, 2023
@michael-markl
Copy link
Member

@sarahsporck What needs to be done to unblock this task from #837? I think, we only need to agree on a route, so that we can generate the links to the correct URL on which the organizations can verify/reject an application?

@sarahsporck
Copy link
Contributor Author

Exactly. I am currently still struggeling to decode on the route in the other task. I guess what makes the most sense is sth. Like /verifizieren/{application_verification_id}?accessKey={accessKey}. Do you agree?

@michael-markl
Copy link
Member

If it makes it any easier, we can also do /verifizieren/{application_verification_id}/{accessKey}.
However, we might actually want to rename verifizieren => antrag-verifizieren?

@sarahsporck
Copy link
Contributor Author

Hmm. As far as I know there is no specific ruling when to use path and query params. Generally, the path leads to a specific resource and then the query filters/sorts/... the resource. Therefore, I'd but the access key into the query param. Are you alright with /antrag-verifizieren/{application_verification_id}?accessKey={accessKey}?

@michael-markl michael-markl removed the blocked Task or user story can not be continued at the moment label Mar 9, 2023
@michael-markl
Copy link
Member

Sorry for the late objection: As I wrote in your current PR #857 , we should probably avoid externalizing our interal ids. Also, I originally designed the accessKey to be unique. So we should be able to just omit the application_verification_id in the link and go with either /antrag-verifizieren/{accessKey} or /antrag-verifizieren?accessKey={accessKey} whatever suits you better. Feel free to speak against this :D

@sarahsporck sarahsporck changed the title Send verification E-Mails after creating an application [ApplicationVerification] Send verification E-Mails after creating an application Mar 15, 2023
@sarahsporck sarahsporck self-assigned this Mar 16, 2023
@sarahsporck sarahsporck linked a pull request Mar 16, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio: high Issue must be solved within the next weeks. Task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants