-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ApplicationVerification] Send verification E-Mails after creating an application #836
Comments
@sarahsporck What needs to be done to unblock this task from #837? I think, we only need to agree on a route, so that we can generate the links to the correct URL on which the organizations can verify/reject an application? |
Exactly. I am currently still struggeling to decode on the route in the other task. I guess what makes the most sense is sth. Like |
If it makes it any easier, we can also do |
Hmm. As far as I know there is no specific ruling when to use path and query params. Generally, the path leads to a specific resource and then the query filters/sorts/... the resource. Therefore, I'd but the access key into the query param. Are you alright with |
Sorry for the late objection: As I wrote in your current PR #857 , we should probably avoid externalizing our interal ids. Also, I originally designed the accessKey to be unique. So we should be able to just omit the application_verification_id in the link and go with either |
Is your feature request related to a problem? Please describe.
The referenced organizations of an application need to be informed and verify an application.
Describe the solution you'd like
When a user submits an application and it is stored in the DB, the referenced organizations should each receive a verification e-mail. Think about the text. There already exists a utility to send e-mails in the backend.
[EDIT] The url should be encoded, so that outlook can pick it up. See: #828
Blocked by
The text was updated successfully, but these errors were encountered: