Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cards should have a creator assigned in the DB #615

Closed
michael-markl opened this issue Nov 8, 2022 · 4 comments · Fixed by #669
Closed

Cards should have a creator assigned in the DB #615

michael-markl opened this issue Nov 8, 2022 · 4 comments · Fixed by #669
Assignees
@maxammann @sarahsporck
Labels
prio: high Issue must be solved within the next weeks. user story
Milestone
Verification

Comments

@michael-markl
Copy link
Member

This enables us to invalidate cards created by a single user (eg. if their account has been compromised).
@michael-markl michael-markl added user story prio: high Issue must be solved within the next weeks. labels Nov 8, 2022
@maxammann maxammann added this to the Verification milestone Nov 21, 2022
@maxammann maxammann self-assigned this Nov 21, 2022
@sarahsporck sarahsporck self-assigned this Dec 5, 2022
@sarahsporck
Copy link
Contributor

For clarification who is the creator of a card?
We currently don't persist any users in the DB and as far as I know there is no User Id, also, who is the creator of a card? Is it sufficient to use the User name here or any auto incrementing id? Any ideas? :)

@michael-markl
Copy link
Member Author

With user we actually mean the administrator that creates the card.

@michael-markl
Copy link
Member Author

@maxammann confirm :D

@maxammann
Copy link
Member

Confirmed!

@sarahsporck sarahsporck linked a pull request Dec 13, 2022 that will close this issue
615: add creator to card information #669
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxammann maxammann

@sarahsporck sarahsporck

Labels
prio: high Issue must be solved within the next weeks. user story
Projects
None yet
Milestone
Verification
Development

Successfully merging a pull request may close this issue.

615: add creator to card information digitalfabrik/entitlementcard
3 participants
@maxammann @michael-markl @sarahsporck