Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to disable geocoding when importing #463

Closed
maxammann opened this issue Jan 19, 2022 · 5 comments
Closed

Add a way to disable geocoding when importing #463

maxammann opened this issue Jan 19, 2022 · 5 comments
Labels

Comments

@maxammann
Copy link
Member

maxammann commented Jan 19, 2022

Is your feature request related to a problem? Please describe.
Right now the import will always fail if no geocoding service is defined or it is down.

Describe the solution you'd like
Geocoding should be disable in both cases:

  • geocoding server is down
  • geocoding server is not configured

In the former case a warning should be shown.

@maxammann maxammann added the Task label Jan 19, 2022
@michael-markl
Copy link
Member

On production, I think the importer should simply fail if the geocoding server is down and the server should continue to work with the "old" data (from the last import run)

@maxammann
Copy link
Member Author

You are right, probably only if the latter case is interresting

@steffenkleinle steffenkleinle mentioned this issue Feb 13, 2022
4 tasks
@steffenkleinle
Copy link
Member

I think this should be configured in the build config during our whitelabeling process. We also probably need more configuration options than just disabling/enabling geocoding: Data source, mapping, enabling/disabling specific steps, database configuration to be able to retrieve the right data matching the current build config.

@maxammann
Copy link
Member Author

Yes that makes sense. We should also think about runtime vs compile time flags. The build config contains compile time flags and runtime flags in integreat.

Maybe it could make sense to split this up. Independent of the used build config it should be possible to run an import without geocoding if the nominatim server is offline.

Another thing to keep in mind: the backend propably wont have a build config, but just a normal configuration. Settings in this config should be overridable by a command line argument.

@maxammann maxammann added this to the Improve data source milestone Feb 15, 2022
@maxammann maxammann removed this from the Improve data source milestone Nov 21, 2022
@maxammann
Copy link
Member Author

Closed because it is disablable and failures in the geocoding lead to failed imports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants