Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camera permission is not requested #430

Closed
IzzySoft opened this issue Nov 29, 2021 · 6 comments
Closed

Camera permission is not requested #430

IzzySoft opened this issue Nov 29, 2021 · 6 comments
Labels

Comments

@IzzySoft
Copy link
Contributor

Describe the bug
The CAMERA permission is not requested, and thus cannot be granted either. This makes it impossible to scan the Ehrenamtskarte, for example.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Ausweisen'
  2. Click on 'Jetzt Aktivierungscode einscannen'
  3. See the camera view open
  4. Window stays black, no camera.

Expected behavior
Camera view is shown so the card can be scanned (question remains what the activation code is; I do not remember having received any with my card).

Screenshots
From a black screen? 😉

Desktop (please complete the following information):

  • OS: [e.g. iOS] n/a
  • Browser [e.g. chrome, safari] n/a
  • Version [e.g. 22] n/a

Smartphone (please complete the following information):

  • Device: Fairphone 2
  • OS: Android 10 (LineageOS)
  • Browser n/a
  • Version 2.0.2

Additional context
None so far.

@IzzySoft IzzySoft added the Bug Something isn't working label Nov 29, 2021
@maxammann
Copy link
Member

Thanks for opening this bug. Right now this is intentional, because we do not yet have build flavors.
The currently released version in the Play Store should not have this permission.

We can use this issue to re-add the camera permission as soon as we have build flavors.

@IzzySoft
Copy link
Contributor Author

I see. But if that's intentional, shouldn't that tab be hidden entirely? It's a bit confusing if I'm asked to scan a code and there's no camera to do it 😉

@maxammann maxammann added this to the Verification as User milestone Jan 19, 2022
@maxammann
Copy link
Member

Closing because it will be fixed by #524.

@michael-markl
Copy link
Member

Afaik, this is not done yet although the linked issue is closed. Let's put this as a technical task.

@michael-markl michael-markl added Task and removed Bug Something isn't working low prio labels Sep 27, 2022
@maxammann
Copy link
Member

Yes we basically need to enable the camera permission based on the build config

@maxammann
Copy link
Member

Closing as soon all flavors of this app will have the camera perm. enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants