Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust icons #1

Merged
merged 3 commits into from
Mar 1, 2022
Merged

Adjust icons #1

merged 3 commits into from
Mar 1, 2022

Conversation

steffenkleinle
Copy link
Member

@steffenkleinle
Copy link
Member Author

Do I have to do anything else?

Copy link
Member

@maxammann maxammann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to follow the following steps:

Modify Icons

  1. Take the iconset.json and import it to the Maki Editor.
  2. Apply your changes and download the icons in SVG format and the iconset in JSON format.
  3. Format the JSON with cat iconset.json | jq -MS '.' for better legibility.
  4. Replace the current iconset.json in this repository with the updated one.
  5. Replace all the icons in the svgs_iconset with the SVGs downloaded from the Make Editor.

We can do it together if you want

@steffenkleinle
Copy link
Member Author

You have to follow the following steps:

Modify Icons

1. Take the `iconset.json` and import it to the [Maki Editor](https://www.mapbox.com/maki-icons/editor/).

2. Apply your changes and download the icons in SVG format and the iconset in JSON format.

3. Format the JSON with `cat iconset.json | jq -MS '.'` for better legibility.

4. Replace the current iconset.json in this repository with the updated one.

5. Replace all the icons in the `svgs_iconset` with the SVGs downloaded from the Make Editor.

We can do it together if you want

I did just replace the current paths in the iconset.json with the paths of the new icons. I uploaded the iconset.json to maki and everything looks fine afaict. Could you have a look as well please?

@maxammann
Copy link
Member

I imported the JSON into the editor and exported the icons.

@maxammann maxammann merged commit f5cea26 into gh-pages Mar 1, 2022
@maxammann maxammann deleted the 417-travel-icon branch March 1, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants