VC is throwing exception instead of returning result when credential is expired

[fabrii]

When credential is revoked, vc returns the following object:

{"log": [{"id": "valid_signature", "valid": true},
{"id": "issuer_did_resolves", "valid": true},
{"id": "expiration", "valid": true},
{"id": "revocation_status", "valid": false}],
"results": [{"error": undefined, "log": [Array], "proof": [Object], "purposeResult": [Object], "verificationMethod": [Object], "verified": true}], "statusResult": {"results": [[Object]], "verified": false},
"verified": false}

When credential is expired, vc returns

{"error": [Error: Credential has expired.], "results": [{"credential": [Object], "error": [Error: Credential has expired.], "verified": false}], "verified": false}

VC should return a similar object as the first case with {"id": "expiration", "valid": false}
This has impact in learner credential: https://github.com/openwallet-foundation-labs/learner-credential-wallet/blob/8f9184309c770c015a63579bdb47d9d3ce5d4b93/app/lib/validate.ts#L83

When credential is expired, a generic Error is thrown, and the reason is lost.

[fabrii]

This was working correctly with vc 7.0.0, but stopped working with vc 8.0.0.

I tracked down the issue to this commit b97ca64

In particular, it changed this line

Meanwhile, in learner credential, at https://github.com/openwallet-foundation-labs/learner-credential-wallet/blob/8f9184309c770c015a63579bdb47d9d3ce5d4b93/app/lib/validate.ts#L82 it is checked that the log entry should exist. If it doesn´t, it throws a generic error.

@dmitrizagidulin
@kezike