Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider more specific API names for ASN.1 conversions #257

Open
dlongley opened this issue May 18, 2015 · 1 comment
Open

Consider more specific API names for ASN.1 conversions #257

dlongley opened this issue May 18, 2015 · 1 comment

Comments

@dlongley
Copy link
Member

Our APIs are named following this convention thingToAsn1. However, that doesn't make it clear what kind of ASN.1 structure is being produced. Instead, we could, for example, change publicKeyToAsn1() to publicKeyToAsn1('SubjectPublicKeyInfo'), keeping SubjectPublicKeyInfo as a deprecated default.
@dlongley
Copy link
Member Author

Similarly, privateKeyToAsn1 could take RSAPrivateKey or PrivateKeyInfo as parameters, instead of using the unclear wrapRsaPrivateKey method.

See: #258.

@ryan-ally ryan-ally mentioned this issue Nov 5, 2022
Open
@Centaurioun Centaurioun mentioned this issue Dec 25, 2022
Open
@snyk-bot snyk-bot mentioned this issue Dec 26, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dlongley