From 2637b72c1390a05fe5791df1de481934aff410e3 Mon Sep 17 00:00:00 2001 From: Marton Nagy Date: Mon, 19 Jul 2021 21:48:42 +0200 Subject: [PATCH] Disables flaky test suite of InstrumentedSource.bufferedSource CHANGELOG_BEGIN CHANGELOG_END --- .../com/daml/metrics/InstrumentedSourceSpec.scala | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/ledger/metrics/src/test/suite/scala/com/daml/metrics/InstrumentedSourceSpec.scala b/ledger/metrics/src/test/suite/scala/com/daml/metrics/InstrumentedSourceSpec.scala index 5d8d6b8c32f5..424c7325ce0a 100644 --- a/ledger/metrics/src/test/suite/scala/com/daml/metrics/InstrumentedSourceSpec.scala +++ b/ledger/metrics/src/test/suite/scala/com/daml/metrics/InstrumentedSourceSpec.scala @@ -143,6 +143,7 @@ final class InstrumentedSourceSpec extends AsyncFlatSpec with Matchers with Akka } } + // this test suite is disabled since it's timing related expectations proven to be very flaky in automated tests behavior of "InstrumentedSource.bufferedSource" def throttledTest(producerMaxSpeed: Int, consumerMaxSpeed: Int): Future[List[Long]] = { @@ -166,7 +167,7 @@ final class InstrumentedSourceSpec extends AsyncFlatSpec with Matchers with Akka def samplePercentage(samples: List[Long])(filter: Long => Boolean): Double = samples.count(filter).toDouble / samples.size.toDouble * 100.0 - it should "signal mostly full buffer if slow consumer" in { + it should "signal mostly full buffer if slow consumer" ignore { throttledTest( producerMaxSpeed = 10, consumerMaxSpeed = 5, @@ -176,7 +177,7 @@ final class InstrumentedSourceSpec extends AsyncFlatSpec with Matchers with Akka } } - it should "signal mostly empty buffer if fast consumer" in { + it should "signal mostly empty buffer if fast consumer" ignore { throttledTest( producerMaxSpeed = 10, consumerMaxSpeed = 20, @@ -186,7 +187,7 @@ final class InstrumentedSourceSpec extends AsyncFlatSpec with Matchers with Akka } } - it should "signal mostly empty buffer if speeds are aligned" in { + it should "signal mostly empty buffer if speeds are aligned" ignore { throttledTest( producerMaxSpeed = 10, consumerMaxSpeed = 10, @@ -196,7 +197,7 @@ final class InstrumentedSourceSpec extends AsyncFlatSpec with Matchers with Akka } } - it should "signal mostly empty buffer if consumer slightly faster" in { + it should "signal mostly empty buffer if consumer slightly faster" ignore { throttledTest( producerMaxSpeed = 10, consumerMaxSpeed = 12, @@ -206,7 +207,7 @@ final class InstrumentedSourceSpec extends AsyncFlatSpec with Matchers with Akka } } - it should "signal mostly full buffer if consumer slightly slower" in { + it should "signal mostly full buffer if consumer slightly slower" ignore { throttledTest( producerMaxSpeed = 10, consumerMaxSpeed = 8,