Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect instructions for API Intro Example #182

Closed
bame-da opened this issue Apr 4, 2019 · 4 comments
Closed

Incorrect instructions for API Intro Example #182

bame-da opened this issue Apr 4, 2019 · 4 comments

Comments

@bame-da
Copy link
Contributor

bame-da commented Apr 4, 2019

@gleber-da Submitted this one via the support widget from https://docs.daml.com/app-dev/ledger-api-introduction/index.html#example-project-ping-pong:

As per recommendation in the screenshot, I did the following:

~/tmp ❯❯❯ ls
~/tmp ❯❯❯ da new example-ping-pong-grpc-java ping-pong-java
quickstart-java  Built-in template for version: 100.11.23
~/tmp ❯❯❯ ls
~/tmp ❯❯❯

The promised directory is nowhere to be found and the command output is not explaining what has happened.

I can confirm the above behaviour. The command da new example-ping-pong-grpc-java ping-pong-java seems to result in the available templates being listed which is rather odd. Not worth fixing in the old assistant anymore, but worth being aware that bad da new commands result in no error message.

We should simply change the instructions to get the example form GitHub. I think the API example has been merged with the java examples into https://github.com/digital-asset/ex-java-bindings. @gerolf-da @pajb-da, could you confirm?

@gerolf-da
Copy link
Contributor

@bame-da: should the java-bindings simply refer to quickstart in terms of "for an example, look at quickstart"?

@bethaitman-da
Copy link
Contributor

I think this might be worth a bigger rethink, yes; for the meantime, I think this is an easy fix, so I'll do a PR to get it working again.

@gerolf-da
Copy link
Contributor

@bethaitman-da: In the PR I removed all references to the ping-pong templates, since they are not even in the DAML repo anymore and thus also aren't checked on commit.

@gerolf-da
Copy link
Contributor

Fixed by #216. The instructions now point to the java bindings examples on GitHub. Thanks @bethaitman-da.

cbley-da added a commit that referenced this issue May 6, 2022
Since [rules_nixpkgs#191] has been merged, we can drop the haskell-arm-m1.patch from rules_nixpkgs.

Also, rules_nixpkgs has been split into several components which need to be
added explicitly in `deps.bzl`, see [#182].

[#191]: tweag/rules_nixpkgs#191
[#182]: tweag/rules_nixpkgs#182
cbley-da added a commit that referenced this issue May 6, 2022
Since [rules_nixpkgs#191] has been merged, we can drop the `rules-nixpkgs-arm.patch` from rules_nixpkgs.

Also, rules_nixpkgs has been split into several components which need to be
added explicitly in `deps.bzl`, see [#182].

[#191]: tweag/rules_nixpkgs#191
[#182]: tweag/rules_nixpkgs#182
cbley-da added a commit that referenced this issue May 10, 2022
…3798)

* Update `rules_nixpgks` to HEAD

Since [rules_nixpkgs#191] has been merged, we can drop the `rules-nixpkgs-arm.patch` from rules_nixpkgs.

Also, rules_nixpkgs has been split into several components which need to be
added explicitly in `deps.bzl`, see [#182].

[#191]: tweag/rules_nixpkgs#191
[#182]: tweag/rules_nixpkgs#182

* Adapt `compatibility/deps.bzl`

* Update platforms repository to version 0.0.4

It has been updated in rules_nixpkgs, so this just follows suite.

* Pass through `isClang` attribute for the cc-toolchain

In rules_nixpkgs, this attribute is now used to determine whether the compiler is clang, see [#216].

[#216]: tweag/rules_nixpkgs#216

CHANGELOG_BEGIN
CHANGELOG_END
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants