-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect instructions for API Intro Example #182
Comments
@bame-da: should the java-bindings simply refer to quickstart in terms of "for an example, look at quickstart"? |
I think this might be worth a bigger rethink, yes; for the meantime, I think this is an easy fix, so I'll do a PR to get it working again. |
@bethaitman-da: In the PR I removed all references to the ping-pong templates, since they are not even in the DAML repo anymore and thus also aren't checked on commit. |
Fixed by #216. The instructions now point to the java bindings examples on GitHub. Thanks @bethaitman-da. |
Since [rules_nixpkgs#191] has been merged, we can drop the haskell-arm-m1.patch from rules_nixpkgs. Also, rules_nixpkgs has been split into several components which need to be added explicitly in `deps.bzl`, see [#182]. [#191]: tweag/rules_nixpkgs#191 [#182]: tweag/rules_nixpkgs#182
Since [rules_nixpkgs#191] has been merged, we can drop the `rules-nixpkgs-arm.patch` from rules_nixpkgs. Also, rules_nixpkgs has been split into several components which need to be added explicitly in `deps.bzl`, see [#182]. [#191]: tweag/rules_nixpkgs#191 [#182]: tweag/rules_nixpkgs#182
…3798) * Update `rules_nixpgks` to HEAD Since [rules_nixpkgs#191] has been merged, we can drop the `rules-nixpkgs-arm.patch` from rules_nixpkgs. Also, rules_nixpkgs has been split into several components which need to be added explicitly in `deps.bzl`, see [#182]. [#191]: tweag/rules_nixpkgs#191 [#182]: tweag/rules_nixpkgs#182 * Adapt `compatibility/deps.bzl` * Update platforms repository to version 0.0.4 It has been updated in rules_nixpkgs, so this just follows suite. * Pass through `isClang` attribute for the cc-toolchain In rules_nixpkgs, this attribute is now used to determine whether the compiler is clang, see [#216]. [#216]: tweag/rules_nixpkgs#216 CHANGELOG_BEGIN CHANGELOG_END
@gleber-da Submitted this one via the support widget from https://docs.daml.com/app-dev/ledger-api-introduction/index.html#example-project-ping-pong:
I can confirm the above behaviour. The command
da new example-ping-pong-grpc-java ping-pong-java
seems to result in the available templates being listed which is rather odd. Not worth fixing in the old assistant anymore, but worth being aware that badda new
commands result in no error message.We should simply change the instructions to get the example form GitHub. I think the API example has been merged with the java examples into https://github.com/digital-asset/ex-java-bindings. @gerolf-da @pajb-da, could you confirm?
The text was updated successfully, but these errors were encountered: