Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support interface inheritance of same-named choices in json-api #13923

Closed
6 tasks done
Tracked by #13973
, #13974 ,  #13653
...
S11001001 opened this issue May 18, 2022 · 0 comments · Fixed by #14410
Closed
6 tasks done
Tracked by #13973
, #13974 ,  #13653
...

support interface inheritance of same-named choices in json-api #13923

S11001001 opened this issue May 18, 2022 · 0 comments · Fixed by #14410
Assignees
@S11001001
Labels
component/json-api HTTP JSON API roadmap/interfaces https://digitalasset.atlassian.net/browse/DAML-56 team/ledger-clients Related to the Ledger Clients team's components.

Comments

@S11001001
Copy link
Contributor

S11001001 commented May 18, 2022 •
edited
Loading

Design in #13668 (comment)

  • extend domain.ExerciseCommand and domain.CreateAndExerciseCommand with optional choiceInterfaceId
  • change PackageService.ResolveChoiceArgType: accepts the optional choice interface ID, returns Error \/ (TemplateId.RequiredPkg, iface.Type)
  • use the new extra returned data to infer choiceInterfaceId
  • in CommandService #exerciseCommand and #createAndExerciseCommand, use choiceInterfaceId to fill in the new ledger API fields
  • un-ignore this test and fix it

Depends on
This was referenced May 18, 2022
Closed
Closed
@S11001001 S11001001 added component/json-api HTTP JSON API team/ledger-clients Related to the Ledger Clients team's components. labels May 18, 2022
This was referenced May 24, 2022
Closed
Open
Open
@stefanobaghino-da stefanobaghino-da added the roadmap/interfaces https://digitalasset.atlassian.net/browse/DAML-56 label May 25, 2022
@S11001001 S11001001 self-assigned this Jul 6, 2022
@S11001001 S11001001 mentioned this issue Jul 13, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@S11001001 S11001001

Labels
component/json-api HTTP JSON API roadmap/interfaces https://digitalasset.atlassian.net/browse/DAML-56 team/ledger-clients Related to the Ledger Clients team's components.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

overloaded choices in json-api digital-asset/daml
2 participants
@S11001001 @stefanobaghino-da