Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt rxjava bindings to V2 error codes #11587

Closed
mziolekda opened this issue Nov 8, 2021 · 5 comments
Closed

Adopt rxjava bindings to V2 error codes #11587

mziolekda opened this issue Nov 8, 2021 · 5 comments
Assignees
Labels
component/java-ecosystem Java development experience team/ledger-clients Related to the Ledger Clients team's components.

Comments

@mziolekda
Copy link
Contributor

rxjava bindings need to be adopted to the new self-support error codes.
Here is an example place that hes been identified recently:

responseObserver.onError(Status.INVALID_ARGUMENT.asRuntimeException(metadata))

@stefanobaghino-da
Copy link
Contributor

rxjava bindings need to be adopted to the new self-support error codes. Here is an example place that hes been identified recently:

responseObserver.onError(Status.INVALID_ARGUMENT.asRuntimeException(metadata))

Thanks. Can you give a couple of pointer on what is needed for this to happen so to make the process faster?

@stefanobaghino-da stefanobaghino-da added team/ledger-clients Related to the Ledger Clients team's components. component/java-ecosystem Java development experience labels Nov 9, 2021
@stefanobaghino-da
Copy link
Contributor

@mziolekda Still waiting for input on your side. The more input is there, the easier it will be to make sure we're not forgetting something.

@stefanobaghino-da
Copy link
Contributor

Note that the only line you pointed at is a mock, which should not and will not be used to test integration with the actual Ledger API implementation.

@stefanobaghino-da
Copy link
Contributor

@mziolekda Still no information from you. The line that you mentioned is a mock in a test which is not hit (and would give zero actionable data if we used it), so no need to adapt that. #11510 doesn't mention anything else that was assigned to the Application Runtime team.

If you have anything that needs to be covered, I'm listening. If I cannot find anything and I won't receive any further information, I'll close this ticket.

@stefanobaghino-da
Copy link
Contributor

@mziolekda After an exchange with @tudor-da is looks like the only work needed for the Java bindings tests to work has been dealt with as part of #11223 and the self-service error codes can be returned verbatim through the bindings to the client, so no extra work needed. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/java-ecosystem Java development experience team/ledger-clients Related to the Ledger Clients team's components.
Projects
None yet
Development

No branches or pull requests

2 participants