-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt rxjava bindings to V2 error codes #11587
Comments
Thanks. Can you give a couple of pointer on what is needed for this to happen so to make the process faster? |
@mziolekda Still waiting for input on your side. The more input is there, the easier it will be to make sure we're not forgetting something. |
Note that the only line you pointed at is a mock, which should not and will not be used to test integration with the actual Ledger API implementation. |
@mziolekda Still no information from you. The line that you mentioned is a mock in a test which is not hit (and would give zero actionable data if we used it), so no need to adapt that. #11510 doesn't mention anything else that was assigned to the Application Runtime team. If you have anything that needs to be covered, I'm listening. If I cannot find anything and I won't receive any further information, I'll close this ticket. |
@mziolekda After an exchange with @tudor-da is looks like the only work needed for the Java bindings tests to work has been dealt with as part of #11223 and the self-service error codes can be returned verbatim through the bindings to the client, so no extra work needed. Closing. |
rxjava bindings need to be adopted to the new self-support error codes.
Here is an example place that hes been identified recently:
daml/language-support/java/bindings-rxjava/src/test/scala/com/daml/ledger/rxjava/grpc/helpers/TransactionsServiceImpl.scala
Line 58 in 3bed7a9
The text was updated successfully, but these errors were encountered: