chore(tests): Skip waiting for map to completely load in e2e tests #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently e2e tests wait for all network activity to finish before continuing with each test step. The Mapbox library can continue pre-loading tiles for a while and slows down tests
gmaclennan
force-pushed
the
chore/e2e-skip-mapbox-network
branch
from
c6bd2d8
to
5897c5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently e2e tests wait for all network activity to finish before
continuing with each test step. The Mapbox library can continue
pre-loading tiles for a while and slows down tests.
Came across this when setting up tests for the Mapeo ICCA variant