Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Don't transform Observation shape from server #459

Closed
gmaclennan opened this issue Sep 10, 2020 · 0 comments
Closed

chore: Don't transform Observation shape from server #459

gmaclennan opened this issue Sep 10, 2020 · 0 comments

Comments

@gmaclennan
Copy link
Member

For historical reasons, we transform the observation received from the server to a different shape for use within the app. This makes it harder to share code between mobile and desktop and is confusing for developers. (It was a short-term short-cut dating back to when the two apps were developed separately and we had not agreed on a schema for Mapeo, so it was easier than re-writing).

With all the flow types in place it should be relatively easy to remove the transform and adjust all the components to accept the Observation shape as exported from mapeo-schema

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants