feat(sync): set device name with random string at the end #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okdistribute
commented
May 9, 2019
| constructor (props) { | ||
| super(props) | ||
| // recreate this as little as possible | ||
| this._deviceName = this._deviceName || "Android " + crypto.randomBytes(2).toString('hex').slice(0, 3); |
There was a problem hiding this comment.
This is intended to make sure the device name doesn't change every time you open/close sync, not sure if this is the best way to do it
There was a problem hiding this comment.
I switched to generate this once during the lifecycle of the app
FYI whenever the constructor is called, this._deviceName would always be undefined, since it's only called when creating a new instance.
okdistribute
commented
May 9, 2019
| <TouchableNativeFeedback onPress={onPress}> | ||
| <View style={styles.wifiBar}> | ||
| <WifiIcon /> | ||
| <Text style={styles.wifiBarText}> | ||
| <Text style={styles.bold}>Wi-Fi:</Text> {ssid} | ||
| <Text style={styles.bold}>Wi-Fi:</Text> {ssid}, {deviceName} |
There was a problem hiding this comment.
how do we want to display the device name?
There was a problem hiding this comment.
I think this is a good place to put it. Just tweaked formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.