chore: fix type errors in NamespaceSyncState tests #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test-only change fixes a couple of small type errors in our tests for `NamespaceSyncState`.
EvanHahn
commented
Apr 30, 2024
| @@ -190,12 +190,12 @@ test('replicate with updating data', async function (t) { | |||
| for (const key of cm1Keys) { | |||
| if (key.equals(writer1.core.key)) continue | |||
| const core = cm1.getCoreByKey(key) | |||
| core.download({ live: true, start: 0, end: -1 }) | |||
| core?.download({ start: 0, end: -1 }) | |||
There was a problem hiding this comment.
Best I could tell, live was not used in Hypercore at all.
This was referenced Jun 20, 2024
This was referenced Jul 25, 2024
This was referenced Aug 21, 2024
This was referenced Aug 29, 2024
This was referenced Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test-only change fixes a couple of small type errors in our tests for
NamespaceSyncState.