chore: lint-staged improvements #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes two improvements to `lint-staged`: - Run Prettier on all files, not just some extensions. - Only check files, not fix them. This addresses a race condition (search [lint-staged's docs][0] for "race condition"). [0]: https://www.npmjs.com/package/lint-staged
achou11
approved these changes
Apr 11, 2024
| ], | ||
| "*.{js,css,md}": "prettier --write" |
There was a problem hiding this comment.
the inclusion of css here is amusing 😄
This was referenced Jun 20, 2024
This was referenced Jul 25, 2024
This was referenced Aug 21, 2024
This was referenced Aug 29, 2024
This was referenced Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes two improvements to
lint-staged:Run Prettier on all files, not just some extensions.
Only check files, not fix them. This addresses a race condition (search lint-staged's docs for "race condition").
(I know there's some controversy about whether to use
lint-stagedat all, but I think these are improvements we can adopt regardless.)