chore: update Drizzle #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates drizzle-orm and drizzle-kit to the latest versions. Notably, [a drizzle-orm change][0] required a workaround to avoid resolving a promise with something awaitable. [0]: drizzle-team/drizzle-orm@c063144
EvanHahn
commented
Apr 1, 2024
Comment on lines
-242
to
-244
| /** | ||
| * @param {Parameters<import('drizzle-orm/better-sqlite3').BetterSQLite3Database['select']>[0]} fields | ||
| */ |
There was a problem hiding this comment.
This parameter (1) isn't in our type definitions (2) isn't used, so I removed it for simplicity.
achou11
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
Couple of non-blocking suggestions:
-
Update to latest drizzle-orm (v0.30.8)
-
Getting a deprecation warning about the
placeholderexport (think the notice was introduced somewhere in v0.29.x):
Might be worth including an update to the import in this PR, as there are only a couple of callsites.
This was referenced Jun 20, 2024
This was referenced Jul 25, 2024
This was referenced Aug 21, 2024
This was referenced Aug 29, 2024
This was referenced Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates drizzle-orm and drizzle-kit to the latest versions.
Notably, a drizzle-orm change required a workaround to avoid resolving a promise with something awaitable.
I think this is a useful change on its own, but it also blocks upgrading TypeScript to the latest version.