chore: restore bitCount32 test #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitCount32's test is skipped because it is slow, and it's slow because it iterates over all integers between 0 and 2^32. This keeps that test skipped but adds a new test that we can run, which only tests a few inputs. It also speeds up the test-only comparison function by about 9x in my testing.
gmaclennan
approved these changes
Feb 25, 2024
There was a problem hiding this comment.
Great. Was initially hesitant because the idea of the test/comparison bit count is something so simple it doesn't need a test itself, and bitwise functions scare me, but re-reading the slowBitCount function, I think it's obvious enough to be used as a test comparison case.
Looks good to me.
This was referenced Apr 11, 2024
This was referenced Jun 20, 2024
This was referenced Jul 25, 2024
This was referenced Aug 21, 2024
This was referenced Aug 29, 2024
This was referenced Sep 11, 2024
This was referenced Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is not urgent.
bitCount32's test is skipped because it is slow, and it's slow because it iterates over all integers between 0 and 232.
This keeps that test skipped but adds a new test that we can run, which only tests a few inputs. It also speeds up the test-only comparison function by about 9x in my testing.