chore: don't delete own data when leaving a project #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you leave a project, we no longer delete your own data (but still close your writer Hypercore). Because this was the last occurrence of `deleteOwn: false`, I removed the option entirely. Fixes #449.
achou11
approved these changes
Jan 30, 2024
| this.#coreManager.deleteData(namespace, { deleteOwn: true }) | ||
| ) | ||
| namespacesWithoutAuth.flatMap((namespace) => [ | ||
| this.#coreManager.getWriterCore(namespace).core.close(), |
There was a problem hiding this comment.
ah wait is it related to this note in your PR description?
(but still close your writer Hypercore).
There was a problem hiding this comment.
Yeah, that's exactly it. (Let me know if that's wrong!)
There was a problem hiding this comment.
I'm not 100% sure it's the right call. My goal is:
- When you leave, we want to close all Hypercores.
- When you leave, we want to delete all Hypercore data except yours.
Does this express that correctly? (And is my goal correct?)
|
I'll plan to merge this tomorrow morning unless there are any objections. |
This was referenced Apr 11, 2024
This was referenced Jun 20, 2024
This was referenced Jul 25, 2024
This was referenced Aug 21, 2024
This was referenced Aug 29, 2024
This was referenced Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you leave a project, we no longer delete your own data (but still
close your writer Hypercore).
Because this was the last occurrence of
deleteOwn: false, I removedthe option entirely.
Fixes #449.