-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add functionality to serve offline fallback map #450
Conversation
@@ -88,6 +88,7 @@ | |||
"husky": "^8.0.0", | |||
"light-my-request": "^5.10.0", | |||
"lint-staged": "^14.0.1", | |||
"mapeo-offline-map": "^2.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added as a dev dependency but if we want to be more strict about using this specifically, can change to direct or peer dep.
wasn't too keen on the offline map being bundled as of the npm package so i figured it would make sense to let the consumer decide to add the map as a dependency in its own project
35440ea
to
a18ecdc
Compare
f5be6af
to
8aca6f8
Compare
a18ecdc
to
2d75a01
Compare
8aca6f8
to
7412da8
Compare
d6f96b6
to
096e0d9
Compare
7412da8
to
e563dce
Compare
096e0d9
to
3b6d2ce
Compare
e563dce
to
b4d8819
Compare
3b6d2ce
to
e37954e
Compare
b4d8819
to
3e7668c
Compare
e37954e
to
8153ae9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than my annoying nitpicks.
3e7668c
to
773a3d6
Compare
8153ae9
to
ef363dd
Compare
773a3d6
to
771f7df
Compare
ef363dd
to
af62ed3
Compare
af62ed3
to
be88383
Compare
Towards #439
Stacked on #435
Implements a fastify plugin for serving a fallback map in the case of not having an available local "default" static map or being offline. The plugin accepts required options for specifying where the style definition lives and the directory containing the geojson sources (this provides flexibility for consumers that may not necessarily be using something like
mapeo-offline-map
, or happen to change the filesystem structure).TODO: