-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add project.close()
#375
Merged
Merged
Changes from 3 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
8adec47
initial implementation of project.close()
7529dc6
add `close` to Datastore, use `coreManager.close()`
356d4ee
add sqlite as a private field, `.close()` it on `MapeoProject.close()`
1df497d
close dataStores in parallel
e3c395c
await #coreManager.close and dataStore promises
0e7ce31
update multi-core-indexer to alpha8
1062410
update lock
3e33597
Merge branch 'main' of github.com:digidem/mapeo-core-next into feat/p…
ef7f93e
fix package-lock, add tests to close
bd88106
fix `.getMany` test for `project.close()`
904ee40
add tests for creating project after `project.close()`
f218f09
Merge branch 'main' of github.com:digidem/mapeo-core-next into feat/p…
6774279
Merge branch 'main' of github.com:digidem/mapeo-core-next into feat/p…
57ba9fc
* remove 'multiCoreIndexer.removeAllListener()' (the class is already
5fee846
remove cached project in manager after closing project
achou11 1ad7057
remove added listeners in mapeo project after close
achou11 a1b742e
[OPTIC-RELEASE-AUTOMATION] release/v9.0.0-alpha.3 (#404)
optic-release-automation[bot] c286486
Revert "[OPTIC-RELEASE-AUTOMATION] release/v9.0.0-alpha.3 (#404)"
achou11 d54311b
Merge branch 'main' into feat/projectClose
achou11 fd83222
update flaky sync e2e test now that project.close() is implemented
achou11 169af66
const instead of let in close() method
achou11 02ba36e
fix: close cores after indexing is closed
gmaclennan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should only remove listeners that this class has added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. The MultiCoreIndexer is already doing that, so I'll just remove that line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added relevant change in 1ad7057 to remove the listeners added to the
LocalPeers
instance in the constructor. @gmaclennan lmk if this seems like the correct way to go about it