-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update github action steps #322
Conversation
Updates to actions/checkout@v4 and actions/setup-node@v2 Removes deprecation warnings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one non-blocking question
.github/workflows/node.yml
Outdated
- name: Use Node.js ${{ matrix.node-version }} | ||
uses: actions/setup-node@v1 | ||
uses: actions/setup-node@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason to not use v3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just an error on my part
* main: chore: update github action steps (#322) fix: fix mdns discovery (finally) (#323) chore: check npm lockfile version does not change (#321) chore: commit hooks for lint & package-lock chk (#320) feat: define sync capability per namespace (#319) feat: add namespace to peer pre-have messages (#314)
Updates to actions/checkout@v4 and actions/setup-node@v2
Removes deprecation warnings