Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update github action steps #322

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Conversation

gmaclennan
Copy link
Member

Updates to actions/checkout@v4 and actions/setup-node@v2
Removes deprecation warnings

Updates to actions/checkout@v4 and actions/setup-node@v2
Removes deprecation warnings
@gmaclennan gmaclennan self-assigned this Oct 5, 2023
Copy link
Member

@achou11 achou11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one non-blocking question

- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
uses: actions/setup-node@v2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason to not use v3?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an error on my part

@gmaclennan gmaclennan merged commit 49cb4d7 into main Oct 5, 2023
7 checks passed
gmaclennan added a commit that referenced this pull request Oct 5, 2023
* main:
  chore: update github action steps (#322)
  fix: fix mdns discovery (finally) (#323)
  chore: check npm lockfile version does not change (#321)
  chore: commit hooks for lint & package-lock chk (#320)
  feat: define sync capability per namespace (#319)
  feat: add namespace to peer pre-have messages (#314)
@gmaclennan gmaclennan deleted the chore/update-action-steps branch October 26, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants