Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deviceType to project members #455

Closed
gmaclennan opened this issue Jan 30, 2024 · 0 comments · Fixed by #495
Closed

Add deviceType to project members #455

gmaclennan opened this issue Jan 30, 2024 · 0 comments · Fixed by #495
Assignees
Labels
mvp Requirement for MVP

Comments

@gmaclennan
Copy link
Member

Description

We should expose a deviceType for project members, e.g. desktop or mobile, in order to display project members with an appropriate icon. Depends on https://github.com/digidem/mapeo-schema/issues/162

gmaclennan added a commit that referenced this issue Jan 31, 2024
fixes #451 and #452. Does not store deviceType in project deviceInfo
records, which will be done in a follow up PR (see #455) which also
requires changes to @mapeo/schema. `deviceType` is optional, and must be
set in the constructor of MapeoManager. Ideally this should not be
possible to change, but not sure how to enforce that.
gmaclennan added a commit that referenced this issue Feb 8, 2024
* feat: share deviceType with local peers

fixes #451 and #452. Does not store deviceType in project deviceInfo
records, which will be done in a follow up PR (see #455) which also
requires changes to @mapeo/schema. `deviceType` is optional, and must be
set in the constructor of MapeoManager. Ideally this should not be
possible to change, but not sure how to enforce that.

* Incorporate review comments

* fix bug in teardown
@gmaclennan gmaclennan self-assigned this Feb 8, 2024
@ximenabb ximenabb added the mvp Requirement for MVP label Feb 12, 2024
@EvanHahn EvanHahn assigned EvanHahn and unassigned gmaclennan Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mvp Requirement for MVP
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants