Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not delete own data by default when leaving a project #449

Closed
1 task
achou11 opened this issue Jan 29, 2024 · 0 comments · Fixed by #458
Closed
1 task

Do not delete own data by default when leaving a project #449

achou11 opened this issue Jan 29, 2024 · 0 comments · Fixed by #458
Assignees
@EvanHahn
Labels
mvp Requirement for MVP

Comments

@achou11
Copy link
Member

achou11 commented Jan 29, 2024 •
edited
Loading

Description

There are some lingering questions about what leaving a project entails when it comes to data deletion. For the sake of leaning towards the safer side for future work, we should update MapeoProject[kLeaveProject]() to use deleteOwn: false when calling CoreManager.deleteData().

Tasks

  • Update MapeoProject[kLeaveProject]() implementation
@EvanHahn EvanHahn self-assigned this Jan 29, 2024
EvanHahn added a commit that referenced this issue Jan 30, 2024
@EvanHahn
chore: don't delete own data when leaving a project
92fe1ad 
When you leave a project, we no longer delete your own data (but still
close your writer Hypercore).

Because this was the last occurrence of `deleteOwn: false`, I removed
the option entirely.

Fixes #449.
@EvanHahn EvanHahn mentioned this issue Jan 30, 2024
Merged
EvanHahn added a commit that referenced this issue Feb 1, 2024
@EvanHahn
chore: don't delete own data when leaving a project (#458)
a301b75 
When you leave a project, we no longer delete your own data (but still
close your writer Hypercore).

Because this was the last occurrence of `deleteOwn: false`, I removed
the option entirely.

Fixes #449.
@gmaclennan gmaclennan added the mvp Requirement for MVP label Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EvanHahn EvanHahn

Labels
mvp Requirement for MVP
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: don't delete own data when leaving a project digidem/comapeo-core
3 participants
@gmaclennan @EvanHahn @achou11