chore: fix labels in k6 reports #1599
Conversation
📝 Walkthrough📝 WalkthroughWalkthroughThe pull request modifies performance testing configurations in two JavaScript files related to end-user search functionalities. It removes several threshold definitions that include the prefix "enduser" and replaces them with simplified names that begin with "get." The changes streamline the naming conventions for performance metrics, ensuring consistency across the testing framework without altering the underlying logic or error handling in the scripts. Changes
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
tests/k6/tests/enduser/enduserSearchWithThresholds.js(1 hunks)tests/k6/tests/enduser/performance/enduser-search.js(1 hunks)
🔇 Additional comments (2)
tests/k6/tests/enduser/performance/enduser-search.js (1)
11-18: Verify that the new metric names match k6's generated metrics
The simplified naming convention looks good, but we should verify that these names exactly match the metrics that k6 generates during test execution.
✅ Verification successful
The new metric names match k6's generated metrics
The simplified metric names in the code exactly match the metric names used in k6's test execution:
get dialogget dialog activitiesget dialog activityget seenlogsget seenlogget transmissionsget transmissionget labellog
All these names are consistently used across the k6 test files, confirming their validity.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for k6 metric registration or output handling
rg -t js "http_req_duration.*name:" tests/k6/
Length of output: 1984
tests/k6/tests/enduser/enduserSearchWithThresholds.js (1)
17-23: Clarify the purpose of empty threshold arrays
The http_reqs metrics have empty arrays as threshold values. This means no thresholds are being enforced for request counts. Is this intentional? Consider adding appropriate threshold values or documenting why they're left empty.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
dagfinno
changed the title
|
The labels in k6 reports for enduser search was wrong, showing nothing
Description
Related Issue(s)
Verification
Documentation
docs-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)