fix: workaround for github number error in dispatch workflow #1367
Conversation
📝 Walkthrough📝 WalkthroughWalkthroughThe pull request modifies the K6 performance test workflow configuration in the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
.github/workflows/dispatch-k6-performance.yml (1)
43-46: Consider making test paths more maintainableThe change to
type: choicewith predefined options improves usability and prevents errors. However, consider moving these test paths to a reusable workflow variable or configuration file to make future updates easier.Example approach using a reusable variable:
# In a shared config file or at the top of the workflow test_suite_paths: serviceowner_create_dialog: 'tests/k6/tests/serviceowner/performance/create-dialog.js' enduser_simple_search: 'tests/k6/tests/enduser/performance/simple-search.js' # Then in the inputs section options: - ${{ vars.test_suite_paths.serviceowner_create_dialog }} - ${{ vars.test_suite_paths.enduser_simple_search }}
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
.github/workflows/dispatch-k6-performance.yml(3 hunks)
🔇 Additional comments (1)
.github/workflows/dispatch-k6-performance.yml (1)
33-33: LGTM: Explicit type declaration for VUS input
The explicit type: number declaration ensures proper type validation for the virtual users input parameter.
|
🤖 I have created a release *beep* *boop* --- ## [1.28.0](v1.27.1...v1.28.0) (2024-11-05) ### Features * update swagger name generation ([#1350](#1350)) ([94c5544](94c5544)) * **webapi:** Add ExternalReference to dialog search result ([#1384](#1384)) ([431fe16](431fe16)) * **webapi:** Return 410 GONE for notification checks on deleted dialogs ([#1387](#1387)) ([198bebd](198bebd)) ### Bug Fixes * Add system user id to identifying claims ([#1362](#1362)) ([16f160d](16f160d)) * **e2e:** Use pagination in sentinel ([#1372](#1372)) ([a1df0ff](a1df0ff)) * fixed placement of referenced workflow-file ([#1365](#1365)) ([49c1d80](49c1d80)) * workaround for github number error in dispatch workflow ([#1367](#1367)) ([06ee356](06ee356)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Workaround for issue mentioned here: https://github.com/orgs/community/discussions/67182
Made testSuitePath a type choice and added tests to the list
Related Issue(s)
Verification
Documentation
docs-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)Summary by CodeRabbit