Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endre party-identifikator til noe mer fremoverkompatibelt #220

Closed
6 tasks done
Tracked by #29
elsand opened this issue Oct 27, 2023 · 3 comments · Fixed by #497
Closed
6 tasks done
Tracked by #29

Endre party-identifikator til noe mer fremoverkompatibelt #220

elsand opened this issue Oct 27, 2023 · 3 comments · Fixed by #497
Assignees
Labels
analysis Pre-architecture/design work legal Needs legal assessment

Comments

@elsand
Copy link
Member

elsand commented Oct 27, 2023

Introduksjon

I stedet for /org/ og /person/<norsk fnr/dnr> trenger vi noe som kan håndtere hva som kommer fremover , som potensielt kan være utenlandske organisasjoner og personer identifisert med ulike typer identikatorer (kan potensielt være en public key fra en wallet).

Beskrivelse

Det er uklart om det i det hele tatt eksisterer noen noenlunde etablert standard for å enkode identfikatorer av ulike typer. ISO6523 benyttes for europeiske organisasjonsnummer, men vil bare være én type identifikator som må kunne støttes. ISO6523 vanskeliggjør bruk av underenheter/indre enehter, fordi disse da skal uttrykkes sammen med juridisk enhet - informasjon vi ikke nødvendigvis har i alle tilfeller (Altinn skiller i liten grad på ulike typer 9-sifrede orgnr)

For fremoverkompabilitet må dette være et format som støtter ulike kodelister, noe tilsvarende consumer-claims i ID/Maskinporten-tokens og sender/receiver i SBD-en brukt i eFormidling.

Siden dette vil være en identifikator og potensielt fremmednøkkel, trenger vi også å lande en skalar enkoding av dette.

{ns}{identifikator-type}{separator}{identifikator}

  • {ns} vil være et Altinn-spesifikt navnerom for dette, siden dette skal brukes i kontekst av Altinn Autorisasjon
  • {identifikator-type} må være fra en kodeliste over kjente typer av identifikatorer
  • {separator} må være noe som utvetydig skiller type fra identifikator
  • {identifikator} må være verdien som identifiserer parten utfra reglene definert av {identifikator-type}
  • Identifier-type må være en av organization:identifier-{cc}, person:identifier-{cc}. Det legges til grunn at det kan komme andre identifier types her siden (f.eks. did)
  • {cc} må være en ISO 3166-1 alpha 2 landskode i lowercase, f.eks. no. I første omgang støttes bare no
  • Identifier er enhver alfanumeris verdi, og kan innholde .-_/.

Format i ABNF:

rule = ns identifier-type separator identifier
ns = "altinn:"
identifier-type = organization-with-country-code / person-with-country-code
organization-with-country-code = "organization:identifier-" country-code
person-with-country-code = "person:identifier-" country-code
;country-code = alpha alpha  ; ISO 3166-1 alpha-2 country codes
country-code = "no" ; i første omgang støttes kun norske fnr/dnr/orgnr
separator = "::"
identifier = alpha / digit *(alpha / digit / "." / ":" / "-" / "_" / "/")

I XACML må dette være "URI-reference", så vi strukturerer dette som urn-er. Eksempel-verdier:

urn:altinn:person:identifier-no::12345678901
urn:altinn:organization:identifier-no::912345678

Oppgaver

Preview Give feedback

Se også

@elsand
Copy link
Member Author

elsand commented Jan 9, 2024

@benedicteos

@oskogstad
Copy link
Collaborator

#390

@knuhau
Copy link
Collaborator

knuhau commented Jan 30, 2024

#395

arealmaas pushed a commit that referenced this issue Feb 28, 2024
🤖 I have created a release *beep* *boop*
---


## 1.0.0 (2024-02-28)


### Features

* Add element count to eu list dto
([#414](#414))
([934fa93](934fa93))
* Add purge functionallity separate from soft delete.
([#483](#483))
([1349efb](1349efb))
* Add SeenBy per user
([#368](#368))
([c68db9e](c68db9e))
* **azure:** parameterize SKUs
([#364](#364))
([9c27c74](9c27c74))
* change format of party identifier
([#376](#376))
([27e6744](27e6744)),
closes [#220](#220)
* Container app revision verification on deploy
([#392](#392))
([db13a89](db13a89))
* Slack notifier IaC
([#341](#341))
([80c3579](80c3579))


### Bug Fixes

* 412 status on multiple requests without revision header
([#427](#427))
([047cf71](047cf71))
* add APIM base uri for dialogporten
([948b9a4](948b9a4))
* add apim base uri for staging
([#451](#451))
([580d946](580d946))
* add base uri for web api
([#425](#425))
([0aa941b](0aa941b))
* add correct APIM base uri for dialogporten
([713771a](713771a))
* add correct baseuri for altinn events
([#496](#496))
([74940ab](74940ab))
* Add null checks, set lists to empty if null
([#434](#434))
([f264aec](f264aec))
* **azure:** fix postgresql auth config
([#357](#357))
([4a4757f](4a4757f))
* **azure:** remove default value for KEY_VAULT_SOURCE_KEYS
([#418](#418))
([b0d74e8](b0d74e8))
* **azure:** remove default values in params and ensure secure on params
([#415](#415))
([94b9885](94b9885))
* **azure:** rename and fix outputs and pass correct secrets
([#416](#416))
([68f0c8b](68f0c8b))
* build errors for 8.0.200
([#440](#440))
([b133f8f](b133f8f))
* Check Content for null, use DependentRules, disallow empty
localization values
([#413](#413))
([894644a](894644a))
* Correct params for revision verification
([#405](#405))
([4b98348](4b98348))
* Do not allow empty content
([#436](#436))
([a083544](a083544))
* do not prefix swagger document in development
([#491](#491))
([e330ce3](e330ce3))
* remove path to swagger json
([fe1e770](fe1e770))
* rename migration job
([#423](#423))
([3897db2](3897db2))
* restrict container apps to apim ip
([#448](#448))
([1a1f3ad](1a1f3ad))
* Return 410 Gone when updating deleted dialog
([#464](#464))
([2498b0a](2498b0a))
* set base path for swagger json ui
([476fdca](476fdca))
* set base url for swagger json
([#447](#447))
([2161066](2161066))
* shorten secret name for container app job
([#422](#422))
([09b2f30](09b2f30))
* try echoing pgpassword in migration job🤫
([#419](#419))
([fe673a3](fe673a3))
* Use data from events, not from db
([#455](#455))
([469c606](469c606))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this from 🆕 Ny to ✅ Ferdig in Team Juridisk Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analysis Pre-architecture/design work legal Needs legal assessment
Projects
Status: ✅ Ferdig
Development

Successfully merging a pull request may close this issue.

3 participants