feat: Enable FusionCache AutoClone

[oskogstad]

Description

Enables AutoClone feature in FusionCache

Related Issue(s)

• Subparty forsvinner fra party-response #1226

Verification

• Your code builds clean without any errors or warnings
• Manual testing done (required)
• Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

• Documentation is updated (either in docs-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)

Summary by CodeRabbit

• New Features
  • Introduced a new property, EnableAutoClone, in the caching configuration to enhance cache management.
• Bug Fixes
  • Activated the assignment of an empty list to the SubParties property, ensuring no sub-parties are included in the authorized parties result.
• Style
  • Minor formatting adjustments made for improved readability in the caching configuration.

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request introduces changes to two main files: AltinnAuthorizationClient.cs and InfrastructureExtensions.cs. In the AltinnAuthorizationClient, the GetFlattenedAuthorizedParties method now assigns an empty list to the SubParties property, affecting how sub-parties are processed. In InfrastructureExtensions.cs, a new property EnableAutoClone is added to the FusionCacheEntryOptions, which is set to true to allow automatic cloning of cached entries. Minor formatting adjustments were also made, but the overall functionality of the methods remains unchanged.

Changes

File	Change Summary
src/Digdir.Domain.Dialogporten.Infrastructure/Altinn/Authorization/AltinnAuthorizationClient.cs	Modified GetFlattenedAuthorizedParties to assign an empty list to SubParties, affecting sub-party handling.
src/Digdir.Domain.Dialogporten.Infrastructure/InfrastructureExtensions.cs	Added EnableAutoClone property to FusionCacheEntryOptions in ConfigureFusionCache, set to true, with minor formatting adjustments.

Possibly related PRs

• fix: Add separate settings for parties cache, don't cache invalid response from Altinn 2 #1194: Modifies the AltinnAuthorizationClient class, specifically the caching mechanism for authorized parties.
• chore: Temp. disable caching for AuthorizedParties requests #1368: Temporarily disables caching for authorized parties in the GetAuthorizedParties method.
• fix: Reenable party list cache, log party name look failure with negative cache TTL #1395: Reintroduces caching for the GetAuthorizedParties method, connecting to the handling of authorized parties.
• chore(app): Temp. disable authorized parties cache #1512: Focuses on temporarily disabling the cache for authorized parties.
• fix(app): Sub-parties sometimes missing from authorized parties #1534: Addresses issues with sub-parties missing from authorized parties, relevant to the main PR changes.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 8fc34bf and 453c5ce.

📒 Files selected for processing (2)

• src/Digdir.Domain.Dialogporten.Infrastructure/Altinn/Authorization/AltinnAuthorizationClient.cs (1 hunks)
• src/Digdir.Domain.Dialogporten.Infrastructure/InfrastructureExtensions.cs (1 hunks)

🔇 Additional comments (2)

src/Digdir.Domain.Dialogporten.Infrastructure/Altinn/Authorization/AltinnAuthorizationClient.cs (1)

124-124: LGTM! The change improves caching compatibility.

The assignment of an empty list to party.SubParties after processing ensures clean serialization and prevents potential circular references, which is essential for proper cache cloning.

src/Digdir.Domain.Dialogporten.Infrastructure/InfrastructureExtensions.cs (1)

343-345: LGTM! Enabling AutoClone improves cache safety.

Setting EnableAutoClone = true ensures that cached objects are cloned when retrieved, preventing unintended modifications to cached data. This is particularly important for complex objects like authorized parties.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud