Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local testing #59

Open
Fran-cois opened this issue Feb 20, 2021 · 2 comments
Open

Local testing #59

Fran-cois opened this issue Feb 20, 2021 · 2 comments
Labels
question Further information is requested

Comments

@Fran-cois
Copy link

Status :

Installing Dependencies can be tricky (see issues #2 #38 )

Proposal :

Having a dockerfile + command to execute AMIE tests

@lgalarra lgalarra added the question Further information is requested label Feb 22, 2021
@lgalarra
Copy link
Collaborator

Hi François,

I am kind of a fan of Docker but I am wondering whether we need for AMIE since we are using Maven. The only difficulty I encountered in the current setting comes from the fact that Javatools is not integrated in AMIE (and is not automatically installable). Could you please elaborate on the advantages of testing AMIE in a Docker environment?

Best,
Luis

@Fran-cois
Copy link
Author

Hello Luis,

As you said, my first motivation to create this issue was to be able to test the code easily, and the javatools dependency was my first issue while testing.
I would like to add more advantages :

  • Debugging (critical), an issue might be linked to a java version, jvm version or even a local operating system issue. Moreover, settings the environment parameter allows a better collaboration; I can work on a linux or windows based computer and be sure that it does not affect the contribution quality.
  • Build and run latest AMIE anywhere (nice to have), non-java user might want to have the latest version of amie without the hassle to install java lib and tools .
  • CD/CI flexibility (nice to have) , In issue Configure abstruse ci  #62 , I have proposed abstruse CI, which is self-hosted, if it does not work, other ci can use this configuration.
  • Help for issue Simple GUI for AMIE  #60 (nice to have), one common practice is to declare the gui service in a docker file to launch both the gui and amie.

Cheers,

François

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants