minPresenceAhead crashed application

[romasho]

Describe the bug
Using minPresenceAhead completely breaks the application in some cases (most likely when the content is larger than the page)

To Reproduce
Steps to reproduce the behavior including code snippet (if applies):

1. Go to https://react-pdf.org/repl?example=orphans-and-widows
2. Change widows={4} to minPresenceAhead={4}
3. See error

[zakpucci]

+1 experienced this as well.

[carlobeltrame]

I have occasionally run into the same problem. I'll try to debug it soon.
It looks to me like react-pdf gets into an infinite loop layouting and re-layouting the same page over and over again.
Setting a lower value to minPresenceAhead often reduces the chances of the problem happening.

[carlobeltrame]

First results indicate that a vertical margin on the element following the minPresenceAhead element causes the issue - when I remove the margin or replace it with padding, it seems to work. This can also be observed in the REPL: It works if you first remove the style={{ marginTop: 550 }} from the "Orphans example" Text element.

[carlobeltrame]

I reworked the code which deals with minPresenceAhead and created a PR in #2400. @romasho @zakpucci If you can, please test whether it fixes the problems you observed on your side.

[zakpucci]

Thanks @carlobeltrame, will test this out today. Experiencing another anomaly that I'll drop an issue in for later today. Very long PDF document halts at a specific page and jumbles all of the remaining text onto one page overlapping itself. Only happening on very long documents. Wondering if this could also be a side effect of the minPresenceAhead bug, will will test and get back to you with what I find.

[carlobeltrame]

I haven't experienced that one myself, and I'm generating documents of up to 120 pages sometimes. But let's see.

[carlobeltrame]

@zakpucci have you had a chance to test whether my fix works in your case?