Too big margin makes hang-up CPU.

[fmy]

Describe the bug
Too big margin styles like 1000 make rendering freeze.

To Reproduce
Steps to reproduce the behavior including code snippet (if applies):

1. Go to this repl
2. Change marginTop to 1000 from 100.
3. Browser hang-up

Expected behavior
At least it should crash or timeout.

Screenshots

Desktop (please complete the following information):

• OS: [e.g. MacOS, Windows] both
• Browser [e.g. chrome, safari] any browser and node environment
• React-pdf version [e.g. v1.1.0] @react-pdf/[email protected] & @react-pdf/[email protected]

[oviniciuslara]

I have reproduced this as well

[jeetiss]

the same with fontSize

[oviniciuslara]

@jeetiss this seems to be a generic problem with everything that goes over the page space, there is a lot of similar issues.

The root cause of this should be tracked down to fix this permanently. Do you have any idea where the problem lay down?

[oviniciuslara]

I saw two different problems with this package:

1. Crashes if some element is positioned out of the page or if it overflows the page.
2. Crashes if the actual page has a lot of content, thus using a lot of memory.

For static pages I think just adding a checker to verify if the element is inside the page is enough to avoid this situation, the problem is with dynamic content that could lead to the same situation. At least the package should throw an intuitive log about it, not crashing the entire browser.

About the memory limit we should also throw an intuitive log and ignore further elements before reached a memory limit.

Also, this is just a workaround based on simple analysis, accordingly to the root cause of this CPU crasher the solution may be different.

[oviniciuslara]

@diegomura do you have any knowledge about this that could help?

I consider this issue a VERY HIGH since it affects rendering, the core of this package.

[jeetiss]

Yet another example of rendering freeze

• rendering freeze when text is empty

[kdubb1337]

Related issue for me. I have a very long View that should be page wrapped, which works fine. But then when I add any padding to the containing Page it hangs.

[bezchristo]

Getting the same issue when the image doesn't fit on one page.

[carlobeltrame]

It's possible that the long element freeze could be fixed in #2400. I found some problems (including some potential infinite loops) in the page breaking algorithm there and was able to fix them. If anyone has the means to test that PR, would be highly appreciated.

[diegomura]

Thanks @carlobeltrame . Since your PR change this logic considerably and we havent' heard again about this I'll close it. It can be opened again if someone says this still happens