Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend NodeRule to any Dragonfly action #79

Closed
synkarius opened this issue Jul 27, 2015 · 2 comments
Closed

Extend NodeRule to any Dragonfly action #79

synkarius opened this issue Jul 27, 2015 · 2 comments
Labels
Enhancement Enhancement of an existing feature
Milestone

Comments

@synkarius
Copy link
Collaborator

  • make it do more than Text
@synkarius synkarius added the Enhancement Enhancement of an existing feature label Jul 27, 2015
@synkarius synkarius modified the milestones: v6, v5 Jul 27, 2015
@synkarius
Copy link
Collaborator Author

I realized, partially because of your reaction, that the way I set up the HintNode constructor was rather unintuitive, so I reworked it. It's more similar to a MappingRule now, spec first, then a Dragonfly action, then children, then extras, then defaults.

@ghost
Copy link

ghost commented Aug 7, 2015

Hey, it's an improvement! There's a little trade-off in terms of readability versus efficiency. Really that's inconsequential. When I have more free time review the code a little more and see what I can whip up.

Overall using the MappingRule as a model or even better incorporating features into MappingRule is something that should be given some thought. Not only does it increase the readability but also the reusability of code. Ideally the more centralized features can be within the CCR and apps folder the better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Enhancement of an existing feature
Projects
None yet
Development

No branches or pull requests

1 participant