Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code to check for required dragonfly version #568

Closed
kendonB opened this issue Jun 5, 2019 · 3 comments
Closed

Add code to check for required dragonfly version #568

kendonB opened this issue Jun 5, 2019 · 3 comments
Assignees
Labels
New Feature A new feature that is not currently implemented.

Comments

@kendonB
Copy link
Collaborator

kendonB commented Jun 5, 2019

As per the gitter chat.

@kendonB
Copy link
Collaborator Author

kendonB commented Jun 5, 2019

There should probably be dependency checking near the top of _caster.py so that no Caster modules load unless the required version of a package is installed. E.g. accepting lists for AppContext titles and executables is new in dragonfly2 version 0.14.0.
This would make it easier for people to see what's going on.
Something like this:
import pkg_resources
pkg_resources.require("dragonfly2 >= 0.14.0")

@LexiconCode LexiconCode added the Enhancement Enhancement of an existing feature label Jun 6, 2019
@LexiconCode LexiconCode self-assigned this Jun 24, 2019
@LexiconCode
Copy link
Member

All right @kendonB let's see if it works on bounty source. I think it will trigger when you close the issue.

@LexiconCode LexiconCode added New Feature A new feature that is not currently implemented. and removed Enhancement Enhancement of an existing feature labels Jun 24, 2019
@kendonB
Copy link
Collaborator Author

kendonB commented Jun 24, 2019

I have tested your fix and it forced me to install the new version of dragonfly. Great! closing

@kendonB kendonB closed this as completed Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature A new feature that is not currently implemented.
Projects
None yet
Development

No branches or pull requests

2 participants