Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BringMe path ends in .toml.defaults instead of .toml #338

Closed
LexiconCode opened this issue Dec 11, 2018 · 5 comments
Closed

BringMe path ends in .toml.defaults instead of .toml #338

LexiconCode opened this issue Dec 11, 2018 · 5 comments

Comments

@LexiconCode
Copy link
Member

LexiconCode commented Dec 11, 2018

The path is found in the settings.toml.

BRINGME_DEFAULTS_PATH = "E:/NatLink/NatLink/MacroSystem/caster/bin/share/bringme.toml.defaults"
Perhaps defaultsbringme.toml

@comodoro
Copy link
Contributor

This file contains the defaults if no bringme.toml exists, then it is copied there, so it is not being used as TOML. Do as you see fit, if I had a candidate for name change (other than those in #336 ), it would be the bin directory (it implies binary)

@LexiconCode
Copy link
Member Author

I gotta say I love the functionality of what you've done with the BringMe command.

It might be time to move everything that has a default setting into a centralized file. That way it is clear were to include defaults as people continue to contribute. I'll start with moving the default settings out of settings.py into a new file. Once that's implemented I'll revisit here and add your default as well.

What do you think?

@comodoro
Copy link
Contributor

Well… I agree with the settings.py file containing default settings does not seem right. As for moving all settings into one huge file… I don't know. I think having a file for each module or thing, which does not affect other settings files in any way, might not be a bad idea. And having settings.py refactored accordingly. But it is just a thought, a topic for discussion:-)

As for bring me, I wanted to make a GUI similar to the existing Caster GUIs, because if you add a key, you may want to make sure that you did not mispronounce it or something( maybe it is just me), but I remember gRPC was the new thing and my attempts at making it work with Caster did not go well.

@LexiconCode
Copy link
Member Author

LexiconCode commented Dec 12, 2018

Take a look at gRPC as with experimental integrated dragonfly with working examples.

@LexiconCode
Copy link
Member Author

I'm going to close this issue for now. Thanks for your thoughts on the matter. Will revisit in the future as time allows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants