Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipe editor fields #178

Open
UppaJung opened this issue May 6, 2022 · 1 comment
Open

Recipe editor fields #178

UppaJung opened this issue May 6, 2022 · 1 comment
Assignees

Comments

@UppaJung
Copy link
Contributor

UppaJung commented May 6, 2022

Mark required fields required. Mark optional fields (e.g., length) as optional.

Is it required to label fields in the field rather than putting a sample value? For length, "32" would be the correct sample field (the default length). For a web address "example.com".

For secret, instead of "Maximum Length (16-999)" should be "Length, in bytes (16-999)" with default of "32" in text field.
For password, instead of "Maximum Character Length (8-999)" should be "Maximum length, in characters (16-999)" with "no length limit".

Since we're putting length limits into that box, might as well add the sequence number and have everything done in this UI?

Rather than leave the recipe editor, why not make it modal, add a cancel button, and if cancelled go back to list of recipes?

@angelix
Copy link
Contributor

angelix commented May 11, 2022

Mark required fields required. Mark optional fields (e.g., length) as optional.

Done

Is it required to label fields in the field rather than putting a sample value? For length, "32" would be the correct sample field (the default length). For a web address "example.com".

Added placeholder values

For secret, instead of "Maximum Length (16-999)" should be "Length, in bytes (16-999)" with default of "32" in text field. For password, instead of "Maximum Character Length (8-999)" should be "Maximum length, in characters (16-999)" with "no length limit".

Done

Since we're putting length limits into that box, might as well add the sequence number and have everything done in this UI?

I'll try that

Rather than leave the recipe editor, why not make it modal, add a cancel button, and if cancelled go back to list of recipes?

I have to change a bit the implementation

@angelix angelix reopened this May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants