update build guide #7167
Open
update build guide #7167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AJenbo
reviewed
Jun 25, 2024
Comment on lines
+149
to
+151
| This section is about compiling binary executables for Windows on a Linux system host via [MinGW](https://www.mingw-w64.org/). It's not about compiling for Windows on a Windows host via MinGW. So you first need a Linux system host. If you don't, you can also try WSL (Windows Subsystem for Linux) on Windows. | ||
|
|
||
| If you have any problems with the build process, please refer to the configuration files in the `.github/workflows` folder. These files are automatically executed by the [GitHub Actions](https://docs.github.com/en/actions) service to automate the build. Under the environment described by these configuration files, the compilation is more likely to succeed. |
There was a problem hiding this comment.
Suggested change
| This section is about compiling binary executables for Windows on a Linux system host via [MinGW](https://www.mingw-w64.org/). It's not about compiling for Windows on a Windows host via MinGW. So you first need a Linux system host. If you don't, you can also try WSL (Windows Subsystem for Linux) on Windows. | |
| If you have any problems with the build process, please refer to the configuration files in the `.github/workflows` folder. These files are automatically executed by the [GitHub Actions](https://docs.github.com/en/actions) service to automate the build. Under the environment described by these configuration files, the compilation is more likely to succeed. | |
| This section details how to compile a Windows executable using [MinGW](https://www.mingw-w64.org/) on a Linux system, not on a Windows system. If you are using Windows, you can use WSL (Windows Subsystem for Linux) to accomplish this. |
Trihedraf
suggested changes
Jun 25, 2024
|
|
||
| ``` | ||
| ```bash | ||
| # Only tested on Ubuntu 22. This won't work on Ubuntu 24 (they are renamed in Ubuntu 24). |
There was a problem hiding this comment.
Suggested change
| # Only tested on Ubuntu 22. This won't work on Ubuntu 24 (they are renamed in Ubuntu 24). | |
| # Only tested on Ubuntu 22.04 |
This is still the command for these on 24.04
|
|
||
| ``` | ||
| ```bash | ||
| # Only tested on Ubuntu 22. This won't work on Ubuntu 24 (they are renamed in Ubuntu 24). |
There was a problem hiding this comment.
Suggested change
| # Only tested on Ubuntu 22. This won't work on Ubuntu 24 (they are renamed in Ubuntu 24). | |
| # Only tested on Ubuntu 22.04 |
This is still the command for these on 24.04
| @@ -173,22 +181,30 @@ cd devilutionx | |||
|
|
|||
| ### Installing dependencies on WSL, Debian and Ubuntu | |||
|
|
|||
| The following compilation process has been tested on `ubuntu-22.04`. Success is not guaranteed on Linux distributions other than Ubuntu 22. | |||
There was a problem hiding this comment.
Suggested change
| The following compilation process has been tested on `ubuntu-22.04`. Success is not guaranteed on Linux distributions other than Ubuntu 22. | |
| The following compilation process has been tested on `ubuntu-22.04`. Success is not guaranteed on Linux distributions other than Ubuntu 22.04 |
There was a problem hiding this comment.
@ZhiZe-ZG Ubuntu's version are YY.MM, there is one every 6 month, and a long term every 2 years.
23.10 = October 2023
24.04 LTS = April 2024
24.10 = October 2024
...
26.04 LTS = April 2026
So that's why the minor version (month) is important to include and not just the major (year).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update build guide about compiling for Windows via MinGW on Linux:
The old guide did not mention the Ubuntu version. The current compilation environment (of
.github/workflows) has not been upgraded to Ubuntu 24.