Added spacing between list items #7401
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3,8 +3,9 @@ | |||
| p:last-child { margin-bottom: 0; } | |||
|
|
|||
| ul, ol { | |||
| margin-top:0.8em; | |||
| margin-bottom:0.8em; | |||
| margin-top: 0.8em; | |||
There was a problem hiding this comment.
0.8should be written without a leading zero as.8- Properties should be ordered margin-bottom, margin-top
| margin-top:0.8em; | ||
| margin-bottom:0.8em; | ||
| margin-top: 0.8em; | ||
| margin-bottom: 0.8em; |
There was a problem hiding this comment.
0.8 should be written without a leading zero as .8
| margin-bottom:0.8em; | ||
| margin-top: 0.8em; | ||
| margin-bottom: 0.8em; | ||
| li { margin-bottom: 0.5em; } |
There was a problem hiding this comment.
0.5 should be written without a leading zero as .5
Waithamai
force-pushed
the
7400-add-spacing
branch
from
4546117
to
a5f81cb
Compare
Waithamai
force-pushed
the
7400-add-spacing
branch
from
a5f81cb
to
86235f1
Compare
denschub
approved these changes
Mar 28, 2017
There was a problem hiding this comment.
Tests are green and both @svbergerem and @SuperTux88 thumb'ed up the .5em in the issue, so I guess this is fine to merge.
|
Merged as 38450ea. Thank you very much and congrats to your first PR. 🍪🍰🍪🎉🍪🍰🍪 |
|
Looks much better. :)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7400