Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'no posts yet' message to empty streams #6974

Merged
merged 1 commit into from
Aug 12, 2016

Conversation

svbergerem
Copy link
Member

Fixes #6852 and #5748.

stream
tags
profile

@jhass jhass added this to the 0.6.0.0 milestone Aug 12, 2016
@jhass jhass merged commit eae9e01 into diaspora:develop Aug 12, 2016
jhass added a commit that referenced this pull request Aug 12, 2016
Add 'no posts yet' message to empty streams
@jhass
Copy link
Member

jhass commented Aug 12, 2016

Thank you!

@svbergerem svbergerem deleted the empty-stream branch August 12, 2016 12:22
@paskalito
Copy link

thanks a lot :)

just wanted to ask if we really don't want to add the "( for you to see on this pod)" to the message, since it is more correct and hopefully helps people to understand how federation works. (and could point people to search elswheren and then maybe find what theyre looking for.)

@svbergerem
Copy link
Member Author

@paskalito "There are no posts yet. (for you to see on this pod)" sounds to me like the user won't be able to find posts on the pod. The message appears in the main stream, the tags stream, the mentions stream, the profile stream and so on.

Maybe "There are no posts in this stream yet."? "There are no posts for you in this stream yet."?

@jhass
Copy link
Member

jhass commented Aug 12, 2016

"There are no posts to display here yet."?

@paskalito
Copy link

i think if possible there sould be diffrent messages for diffrent streams

Main stream > No Posts found! [as there is already a message with more explanation and this one is only to assure that there has been a search done]
Tags stream > No posts shared with you on this pod that contains #tag yet
Mentions stream > You haven't been mentioned yet
Profile stream > no posts shared with you yet
Aspects stream > No posts found! [as there is already a message with more explanation and this one is only to assure that there has been a search done]

on /contacts there is already a message

And if there has to be one for all...

no posts for you found here < that's my new favourite (but my brain is already going nuts)

There are no posts to display you here yet.?

And maybe

A good soulution would als be a simple

No Posts Found message and then one or two lines below in grey and small.
(this can have the following resons)

  • No one postet something with #tag
  • Post is only shared in Aspects you're not a poart of
  • the post has not been federated to this pod yet ( you can try searching on other pods)
  • post may have been deleted

this way the message, "we have searched search is finished but theres is nothing here for you" would be communicatet pretty fast and clear. and there is for interested users some more information about why that is..

(also the "No post Found" could appear as simple centered text right in the place where the "searching" animation took place instead of a box where normally the search result would appear. would maybe be more accurate design language.)

@svbergerem
Copy link
Member Author

There is also the liked, commented and activity stream and maybe others I didn't think about yet. Thus I prefered the "one message fits them all" solution and used the message @jhass proposed. You can see the changes in 1d58df1.

@CSammy CSammy mentioned this pull request Aug 13, 2016
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants