-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dashboard to admin page #6216
Add dashboard to admin page #6216
Conversation
Awesome @svbergerem! But I'm not sure admins go often on the admin panel. Maybe this info should be displayed directly in the right column of the main page, or a small /!\ in the header which would link to this page? |
Because we all know that users pay a lot of attention to the right column ;-) In both of your proposed solutions we would either have to fetch the current d* version every time the admin reloads the page or set up a background job that fetches the current version every n minutes. The first solution sounds bad, the second one will be more complicated. The dashboard is an easy solution, we might want to add some more information about the pod in the future and we can still add some info in the header, the right sidebar or somewhere else in another PR if we think that the dashboard is not enough. |
With a red background like you designed it, it will definitely be seen ;)
Hm, maybe this could be done with something like
Yeah no problem, I just wanted to point that it's probably not very efficient in that state, but it can be a good first step |
This is typically the reason why it shouldn't be here. On stream page, the right bar must not draw any attention unless the user searches something. @svbergerem : I see a warning box saying Error fetching the latest diaspora version. I don't find the wording clear : do you talk about the version number, or about the source code ? |
My code fetches https://api.github.com/repos/diaspora/diaspora/releases/latest and uses the
and
? |
Read more carefully, this is only about the podmins, and we want them to pay attention about this critical message: an update is required. |
"version number" sounds a bit odd to me, I think it's fine the way it is. |
If anybody feels strong about changing something we can always do that in a follow up PR. Thanks! |
Thanks Steffen and Jonne. |
Hey, fantastic, Steffen!
How about:
and
'Fetching the latest version' suggests to me fetching the files rather than simply the meta-information about version number. Perhaps 'fetch' has a very specific meaning to sysadmins, and so is perhaps not ambiguous in this circumstance. But if there is any possibility of ambiguity, I'd suggest the 'plain English' versions I've given above. |
Yes, determining seems to be the better term. How about "Determining latest diaspora* version"? |
I'd be happy with that. However, 'Error determining latest diaspora* version' sounds a bit cumbersome to me, so how about, for the error string: 'Unable to determine latest diaspora* version'? |
Sounds good to me. |
Fixes #3588.
I changed the admin navigation for all admin pages because there were now too many items to display them in one line on some screens.