Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dashboard to admin page #6216

Merged
merged 1 commit into from
Jul 21, 2015

Conversation

svbergerem
Copy link
Member

dashboard
error
outdated
uptodate

Fixes #3588.

I changed the admin navigation for all admin pages because there were now too many items to display them in one line on some screens.

@Flaburgan
Copy link
Member

Awesome @svbergerem! But I'm not sure admins go often on the admin panel. Maybe this info should be displayed directly in the right column of the main page, or a small /!\ in the header which would link to this page?

@svbergerem
Copy link
Member Author

Maybe this info should be displayed directly in the right column of the main page

Because we all know that users pay a lot of attention to the right column ;-)

In both of your proposed solutions we would either have to fetch the current d* version every time the admin reloads the page or set up a background job that fetches the current version every n minutes. The first solution sounds bad, the second one will be more complicated.

The dashboard is an easy solution, we might want to add some more information about the pod in the future and we can still add some info in the header, the right sidebar or somewhere else in another PR if we think that the dashboard is not enough.

@Flaburgan
Copy link
Member

Because we all know that users pay a lot of attention to the right column ;-)

With a red background like you designed it, it will definitely be seen ;)
This would be displayed only to users with administrator rights though, but I think that's what you meant.

In both of your proposed solutions we would either have to fetch the current d* version every time the admin reloads the page or set up a background job that fetches the current version every n minutes.

Hm, maybe this could be done with something like if I didn't check the version in the last hour, perform the check, else just skip it?

The dashboard is an easy solution, we might want to add some more information about the pod in the future and we can still add some info in the header, the right sidebar or somewhere else in another PR if we think that the dashboard is not enough.

Yeah no problem, I just wanted to point that it's probably not very efficient in that state, but it can be a good first step

@ghost
Copy link

ghost commented Jul 21, 2015

With a red background like you designed it, it will definitely be seen ;)

This is typically the reason why it shouldn't be here. On stream page, the right bar must not draw any attention unless the user searches something.

@svbergerem : I see a warning box saying Error fetching the latest diaspora version. I don't find the wording clear : do you talk about the version number, or about the source code ?

@svbergerem
Copy link
Member Author

do you talk about the version number, or about the source code ?

My code fetches https://api.github.com/repos/diaspora/diaspora/releases/latest and uses the tag_name (the version number). Should I change the wording to

Fetching latest diaspora* version number...

and

Error fetching the latest diaspora* version number.

?

@Flaburgan
Copy link
Member

This is typically the reason why it shouldn't be here. On stream page, the right bar must not draw any attention unless the user searches something.

Read more carefully, this is only about the podmins, and we want them to pay attention about this critical message: an update is required.

@jhass
Copy link
Member

jhass commented Jul 21, 2015

"version number" sounds a bit odd to me, I think it's fine the way it is.

@jhass jhass modified the milestones: 0.5.3.0, 0.6.0.0 Jul 21, 2015
@jhass jhass merged commit 484e70a into diaspora:develop Jul 21, 2015
jhass added a commit that referenced this pull request Jul 21, 2015
@jhass
Copy link
Member

jhass commented Jul 21, 2015

If anybody feels strong about changing something we can always do that in a follow up PR.

Thanks!

@Flaburgan
Copy link
Member

Thanks Steffen and Jonne.

@svbergerem svbergerem deleted the admin-page-update-notifications branch July 21, 2015 15:19
@goobertron
Copy link

Hey, fantastic, Steffen!

Should I change the wording to

Fetching latest diaspora* version number...

and

Error fetching the latest diaspora* version number.

?

How about:

Determining which is the latest version of diaspora*

and

Error determining which is the latest version of diaspora*

'Fetching the latest version' suggests to me fetching the files rather than simply the meta-information about version number. Perhaps 'fetch' has a very specific meaning to sysadmins, and so is perhaps not ambiguous in this circumstance. But if there is any possibility of ambiguity, I'd suggest the 'plain English' versions I've given above.

@jhass
Copy link
Member

jhass commented Jul 21, 2015

Yes, determining seems to be the better term. How about "Determining latest diaspora* version"?

@goobertron
Copy link

How about "Determining latest diaspora* version"?

I'd be happy with that. However, 'Error determining latest diaspora* version' sounds a bit cumbersome to me, so how about, for the error string: 'Unable to determine latest diaspora* version'?

@jhass
Copy link
Member

jhass commented Jul 21, 2015

Sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants