use camo for medium and small avatars #5883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,8 +4,8 @@ class AvatarPresenter < BasePresenter | |||
| DEFAULT_IMAGE = ActionController::Base.helpers.image_path('user/default.png') | |||
|
|
|||
| def base_hash | |||
| { small: image_url_small || DEFAULT_IMAGE, | |||
| medium: image_url_medium || DEFAULT_IMAGE, | |||
| { small: image_url(:thumb_small) || DEFAULT_IMAGE, | |||
There was a problem hiding this comment.
Align the elements of a hash literal if they span more than one line.
Space inside { detected.
SuperTux88
force-pushed
the
fix-camo-on-contacts-page
branch
from
2065acf
to
6b28b03
Compare
| { small: image_url_small || DEFAULT_IMAGE, | ||
| medium: image_url_medium || DEFAULT_IMAGE, | ||
| { | ||
| small: image_url(:thumb_small) || DEFAULT_IMAGE, |
There was a problem hiding this comment.
Align the elements of a hash literal if they span more than one line.
SuperTux88
force-pushed
the
fix-camo-on-contacts-page
branch
from
6b28b03
to
81cc0a3
Compare
| medium: image_url_medium || DEFAULT_IMAGE, | ||
| large: image_url || DEFAULT_IMAGE | ||
| { | ||
| small: image_url(:thumb_small) || DEFAULT_IMAGE, |
SuperTux88
force-pushed
the
fix-camo-on-contacts-page
branch
from
81cc0a3
to
56bc37b
Compare
SuperTux88
force-pushed
the
fix-camo-on-contacts-page
branch
from
56bc37b
to
344b198
Compare
denschub
added a commit
that referenced
this pull request
Apr 24, 2015
use camo for medium and small avatars
|
Thank you! 🍪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on the contacts page, external urls were used without camo