Display reshared poll #5782
Merged
Display reshared poll #5782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -14,11 +14,18 @@ app.views.Poll = app.views.Base.extend({ | |||
|
|
|||
| presenter: function(){ | |||
| var defaultPresenter = this.defaultPresenter(); | |||
| var show_form = defaultPresenter.loggedIn && | |||
| !this.model.attributes.already_participated_in_poll; | |||
| var isReshare = (this.model.get('post_type') == 'Reshare'); | |||
There was a problem hiding this comment.
Expected '===' and instead saw '=='.
svbergerem
force-pushed
the
reshared-poll
branch
3 times, most recently
from
6cb7123
to
f023897
Compare
|
Nice work! How about, for the text, "You can participate in this poll on the <%= original_post_link %>." Your text is fine, but this version seems, I think, a little less formal and more inviting. |
svbergerem
force-pushed
the
reshared-poll
branch
from
f023897
to
81cd175
Compare
|
@goobertron Thank you for your suggestion. I changed the text. |
|
Great, thanks! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #4928 and #5565.
