-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite hover effect on conversations with multiple participants in css #5776
Rewrite hover effect on conversations with multiple participants in css #5776
Conversation
Conflicts: app/assets/javascripts/inbox.js app/assets/stylesheets/conversations.css.scss
Looks nice! If you could just indeed clean up the git history a bit? |
11fb385
to
ee5bcd2
Compare
update Changelog remove weird merge thing think of the padding and margin
ee5bcd2
to
a11322f
Compare
@svbergerem ha you're right :) I just assumed everything uses border-box. I pushed the fix |
Rewrite hover effect on conversations with multiple participants in css Conflicts: Changelog.md
Awesome, the hover effect feels much more mature with this PR. Thank you! :) |
Yaay! |
Thanks a lot, @lislis! |
Thank you! |
We noticed that the sliding effect on conversations with a lot of participants has kind of poor performance. I rewrote the effect in css which looks way smoother and isn't that annoying once you have a lot on these conversations.
I had to cherry pick the commit from another fork and adjust it to a backbone refactor. Sry for the weird git things, it made me go crazy.
Opinions and suggestions welcome :D