-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused css and reduce blockquote font-size #5769
Conversation
3bd9ca8
to
feb85db
Compare
@@ -29,7 +29,7 @@ body > div.container { | |||
|
|||
.users { | |||
li.user { | |||
border-bottom: 1px solid $light-grey; | |||
border-bottom: 1px solid $text-grey; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new_styles/new_mixins
overwrote $light-grey
on the desktop version with the same value $text-grey
has. Because that was the only important thing new_styles/new_mixins
did I removed the file and changed this variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using a variable named text-gray for a border seems odd though, maybe just define $text-gray
to $light-gray
and $light-gray
to the actual color in colors.scss
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, this is actually the only place where I should have kept $light-grey
because we import colors.scss
at the beginning of the file. Will change this back to $light-grey
. I didn't change the value of $light-grey
because we also use it in the mobile version.
feb85db
to
6dc18ac
Compare
|
||
/* core */ | ||
@import 'media-box'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer double-quoted strings
Should be ready to merge. |
Thanks! |
Remove unused css and reduce blockquote font-size
No description provided.