Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused css and reduce blockquote font-size #5769

Merged
merged 2 commits into from
Mar 13, 2015

Conversation

svbergerem
Copy link
Member

No description provided.

@@ -29,7 +29,7 @@ body > div.container {

.users {
li.user {
border-bottom: 1px solid $light-grey;
border-bottom: 1px solid $text-grey;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new_styles/new_mixins overwrote $light-grey on the desktop version with the same value $text-grey has. Because that was the only important thing new_styles/new_mixins did I removed the file and changed this variable.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a variable named text-gray for a border seems odd though, maybe just define $text-gray to $light-gray and $light-gray to the actual color in colors.scss?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this is actually the only place where I should have kept $light-grey because we import colors.scss at the beginning of the file. Will change this back to $light-grey. I didn't change the value of $light-grey because we also use it in the mobile version.


/* core */
@import 'media-box';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings

@svbergerem
Copy link
Member Author

Should be ready to merge.

@jhass jhass added this to the next-major milestone Mar 13, 2015
@jhass
Copy link
Member

jhass commented Mar 13, 2015

Thanks!

jhass added a commit that referenced this pull request Mar 13, 2015
Remove unused css and reduce blockquote font-size
@jhass jhass merged commit 2c2b47e into diaspora:develop Mar 13, 2015
@svbergerem svbergerem deleted the remove-unused-css branch March 13, 2015 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants