Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve diaspora.yml comments #5426

Merged
merged 1 commit into from
Nov 29, 2014
Merged

Improve diaspora.yml comments #5426

merged 1 commit into from
Nov 29, 2014

Conversation

axilleas
Copy link
Contributor

I found out that the comments for the new chat feature had single # so I started poking the config file all together fixing some typos, etc.

# The max_resources_per_account attribute limits how many
# concurrent connections one user can have to the server
## The max_resources_per_account attribute, limits how many
## concurrent connections one user can have to the server.
#max_resources_per_account: 5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While at it can you add some empty lines to match the rest of the file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean newlines? On it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Squashed and changed commit message to be more descriptive.

@jhass
Copy link
Member

jhass commented Nov 29, 2014

Alright, #5424 (comment) and we're good to go I think :)

- Fix typos and punctuation
- Add double '#' for comments where missed
- Add newlines where needed
@axilleas
Copy link
Contributor Author

Good, added :)

@jhass jhass added this to the next-major milestone Nov 29, 2014
@jhass jhass merged commit 10453e5 into diaspora:develop Nov 29, 2014
jhass added a commit that referenced this pull request Nov 29, 2014
Improve diaspora.yml comments
@jhass
Copy link
Member

jhass commented Nov 29, 2014

Thank you!

@ghostnegotiator
Copy link

@axilleas great job, config is much clearer now!

@axilleas
Copy link
Contributor Author

Thanks, glad I could help :)

@axilleas axilleas deleted the diaspora_yml branch November 29, 2014 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants