Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload photo mobile. Close #3324 #4004

Merged
merged 1 commit into from
Feb 26, 2013
Merged

Upload photo mobile. Close #3324 #4004

merged 1 commit into from
Feb 26, 2013

Conversation

movilla
Copy link
Contributor

@movilla movilla commented Feb 24, 2013

@Flaburgan
Copy link
Member

yeeha !

@movilla
Copy link
Contributor Author

movilla commented Feb 24, 2013

Oks ready to dance. Travis is happy :]

-# licensed under the Affero General Public License version 3 or later. See
-# the COPYRIGHT file.

:javascript
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're trying to get rid of inlined JavaScript, please refactor that out into a file :)

@jhass
Copy link
Member

jhass commented Feb 24, 2013

And lets add some English: "Add the ability to upload photos from the mobile site" ;)

:javascript
function createUploader(){

var aspectIds = "#{aspect_ids}".split(',');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Problem with #{aspect_ids}" when move to .js Any idea to convert this. Thanks

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, we have gon in for that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@movilla
Copy link
Contributor Author

movilla commented Feb 26, 2013

Oks, these are ready to party.

@jhass
Copy link
Member

jhass commented Feb 26, 2013

Awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants