-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload photo mobile. Close #3324 #4004
Conversation
yeeha ! |
Oks ready to dance. Travis is happy :] |
-# licensed under the Affero General Public License version 3 or later. See | ||
-# the COPYRIGHT file. | ||
|
||
:javascript |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're trying to get rid of inlined JavaScript, please refactor that out into a file :)
And lets add some English: "Add the ability to upload photos from the mobile site" ;) |
:javascript | ||
function createUploader(){ | ||
|
||
var aspectIds = "#{aspect_ids}".split(','); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Problem with #{aspect_ids}"
when move to .js Any idea to convert this. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, we have gon in for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Oks, these are ready to party. |
Awesome, thank you! |
Upload photo mobile. Close #3324
#3324