Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to bootstrap-sass gem #28

Closed
jhass opened this issue Jul 12, 2013 · 5 comments
Closed

Port to bootstrap-sass gem #28

jhass opened this issue Jul 12, 2013 · 5 comments

Comments

@jhass
Copy link
Member

jhass commented Jul 12, 2013

I don't know what vendor/assets/stylesheets/bootstrap.css is, but it doesn't seem to be Bootstrap. If I delete it and activate the bootstrap-sass gem, it looks like this:

about - the diaspora- project - chromium_054

@goobertron
Copy link

I wonder whether Dennis might have used the early draft of the files I was hacking. Because I was creating pages just to last a few days to fill an emergency gap, and because I was very short on time, I just hacked it the easiest way possible, and made a few very small changes to the bootstrap.css file: for example, changing the colour of h2 to blue.

I later reversed these and put my changes into application.css, realising that it was better to leave bootstrap.css as it was (bootstrap was completely new to me, so I only realised its significance later) but, as I wasn't expecting the work I'd done to form the basis of a more permanent site, I didn't worry about that too much.

I'll send you the corrected files (the bootstrap.css which is what appeared on the old project site - where I got all the assets from - and my amended application.css), and you can see whether this solves the issue.

@denschub
Copy link
Member

finally... closing.

🎉

@jhass
Copy link
Member Author

jhass commented Dec 14, 2014

🍰

@denschub
Copy link
Member

❤️

@goobertron
Copy link

You are a ⭐!

Well, you both are.

@denschub denschub removed their assignment Jul 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants