Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply override on ready setting does not prevent custom style layers from being overriden. #2434

Open
Spekel opened this issue Oct 14, 2024 · 0 comments
Labels
Needs testing More feedback/testing would be good

Comments

@Spekel
Copy link

Spekel commented Oct 14, 2024

The problem

Describe the bug
When editing the scene of a custom layout layer, there is not currently a way to edit the control nodes without the properties being overrided by the exported settings at the scene root. Unchecking "Apply Override on Ready" does not prevent this.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the Syles tab.
  2. Add a new premade visual novel style.
  3. Click Vn Textbox Layer, then the Make Custom button at the top followed by Full Layout.
  4. Open the custom_vn_textbox_layer.tscn scene.
  5. Uncheck the Apply Override on Ready option.
  6. Go to the DialogTextPanel Node.
  7. Under Theme Overrides, replace the panel texture with a new StyleBoxTexture material and add a texture to it.
  8. Test the scene, and the custom panel texture will not be used.

Expected behavior
I would expect that disabling apply override on ready would prevent the built-in settings from being used and give the user full control over the custom scene.

System (please complete the following information):

  • OS: Windows 11
  • Godot Version: 4.3
  • Dialogic Version: 2.0 Alpha 15

Solutions

Workaround
In the dialogic_layout_layer.gd file, I changed the apply_export_overrides() function. I changed the last line to
if apply_overrides_on_ready: _apply_export_overrides()

EDIT: this workaround will mess with the other layout layers, so it must be full custom

@Jowan-Spooner Jowan-Spooner added the Needs testing More feedback/testing would be good label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs testing More feedback/testing would be good
Projects
None yet
Development

No branches or pull requests

3 participants
@Jowan-Spooner @Spekel and others