You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The new semantics of trailVertices cause the example of decorateTrail in the manual to break. I think we should come up with a better example of decoratePath. Since the easiest fix to the code:
dot = circle 1 # fc black
dotSep = 0.5
rowSep = width (Dot :: D R2) + dotSep
mkRow n = hcat' (with & sep .~ dotSep) (replicate n dot)
mkTri n = cat' v (with & sep .~ rowSep & catMethod .~ Distrib) $ rows
where
rows = map mkRow [n, n-1 .. 1]
v = fromDirection (1/6 @@ turn)
No longer uses the decoratePath function.
We also need to fix TriangularNumbers.lhs in the gallery, in this case a patch similar to the one above should work.
The text was updated successfully, but these errors were encountered:
I agree we need a better example of decoratePath. In fact, I think the above code is a better way to make that triangle of dots, even with the old semantics of trailVertices! So it was never a very compelling example even to begin with.
I would actually go farther: I think we ought to deprecate decorateTrail and decoratePath, and add a function to lay out diagrams at a list of positions. (We already have position but we should make an unzipped version of it too, often when I use position I find myself using zip as well.) Then the focus turns to creating powerful/useful methods for constructing lists of points. Getting the vertices of a trail or path is only one such method.
The new semantics of
trailVertices
cause the example ofdecorateTrail
in the manual to break. I think we should come up with a better example ofdecoratePath
. Since the easiest fix to the code:No longer uses the
decoratePath
function.We also need to fix TriangularNumbers.lhs in the gallery, in this case a patch similar to the one above should work.
The text was updated successfully, but these errors were encountered: