Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop "xlink:" namespace for SVG 2.0 #91

Open
kostmo opened this issue Sep 21, 2016 · 2 comments
Open

Drop "xlink:" namespace for SVG 2.0 #91

kostmo opened this issue Sep 21, 2016 · 2 comments

Comments

@kostmo
Copy link

kostmo commented Sep 21, 2016

The <a> element generated by the href function in diagrams-core contains a xlink:href attribute.

However, the xlink namespace has been deprecated since SVG 2.

@byorgey
Copy link
Member

byorgey commented Sep 22, 2016

Hi @kostmo , thanks very much for the report! It seems you are right. However, I grepped through the diagrams-core source for xlink and didn't find anything. After a bit of digging it seems that this is actually coming from the svg-builder package. Would you mind re-filing this ticket against the svg-builder repo? Thanks!

(ping: @jeffreyrosenbluth )

@jeffreyrosenbluth
Copy link
Member

It actually comes from diagrams-svg and was originally added in a PR, although I can't remember who submitted it. I'm also confused as to whether SVG is at 1.1 or 2.0, https://www.w3.org/standards/techs/svg#w3c_all. In any event I'll look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants