Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework how we gather model number from targets #28

Open
ventris opened this issue Jun 16, 2019 · 1 comment
Open

Rework how we gather model number from targets #28

ventris opened this issue Jun 16, 2019 · 1 comment

Comments

@ventris
Copy link
Member

ventris commented Jun 16, 2019

Currently we have a list of oids that we scrape to get the model for the model specific oids, and the first one that got data will be the one used.

def model(self, target):
model_oids = [
'.1.3.6.1.2.1.47.1.1.1.1.13.1', # Normal switches
'.1.3.6.1.2.1.47.1.1.1.1.13.1001', # Stacked switches
'.1.3.6.1.2.1.47.1.1.1.1.13.10', # Nexus
'.1.3.6.1.2.1.1.1.0', # Other appliances (sysDescr)
]

This is a problem with juniper mx10k routers as they will send its id number on 1.3.6.1.2.1.47.1.1.1.1.13.1 and not the readable model number.
The model number is send by the 1.3.6.1.2.1.1.1.0 oid on those routers and that is last in the current list.

Evaluate if it is possible to change this without breaking all other targets.

@Zmegolaz
Copy link
Member

I suspect this is the case for more Juniper models, since there's already an entry for ^710-.*.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants